Skip to content

chore(logger): correct homepage link in logger package. #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

chore(logger): correct homepage link in logger package. #1495

merged 1 commit into from
Jun 13, 2023

Conversation

kitsunde
Copy link
Contributor

@kitsunde kitsunde commented Jun 13, 2023 •
edited by dreamorosi
Loading

Description of your changes

Fixed the link in the package.json file of the Logger utility, which as explained in the linked issue, was invalid.

Related issues, RFCs

Issue number: #1498

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Jun 13, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jun 13, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 13, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@kitsunde kitsunde changed the title Fix homepage link core: correct homepage link in logger package. Jun 13, 2023
@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jun 13, 2023
@dreamorosi dreamorosi changed the title core: correct homepage link in logger package. chore(logger): correct homepage link in logger package. Jun 13, 2023
@dreamorosi
Copy link
Contributor

Hi @kitsunde, thank you for opening the PR.

Since this is your first contribution to this project I have took the liberty to go ahead and open an issue (#1498) as well as edit the title and description of the PR. This way I can merge it and you can be credited for the change.

For future reference, please take the time to read through the contributing guidelines and predefined text in the PR body:

Instructions:
1. Make sure you follow our Contributing Guidelines: https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/CONTRIBUTING.md
2. Please follow the template, and do not remove any section/item. If something is not applicable leave it empty, but leave it in the PR.

@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jun 13, 2023
@dreamorosi dreamorosi linked an issue Jun 13, 2023 that may be closed by this pull request
Maintenance: homepage field in the package.json file returns 404 #1498
Closed
2 tasks
@dreamorosi dreamorosi merged commit fb932be into aws-powertools:main Jun 13, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 13, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@dreamorosi dreamorosi self-requested a review June 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi Awaiting requested review from dreamorosi

Assignees

@kitsunde kitsunde

Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/XS PR between 0-9 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: homepage field in the package.json file returns 404
2 participants
@kitsunde @dreamorosi